Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolve reexported CJS modules as named ESM exports #10988

Merged
merged 2 commits into from
Dec 30, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Dec 30, 2020

Summary

Noticed when investigating #10814 that import {jsx} from 'react/jsx-runtime' didn't work as the exported function was not detected

Test plan

Test for named CJS export expanded.

@SimenB SimenB force-pushed the reexported-named-cjs-exports branch from 2f623b6 to 688f0aa Compare December 30, 2020 16:25
@SimenB SimenB merged commit 596ebff into jestjs:master Dec 30, 2020
@SimenB SimenB deleted the reexported-named-cjs-exports branch December 30, 2020 17:04
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants