-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(expect): allow expect.Matchers
generic with single value
#11986
Conversation
a81df58
to
4b06caf
Compare
Thanks. Looks like a good idea. Most probably I can help with the test. See #11985 (comment) |
4b06caf
to
8c0357a
Compare
@mrazauskas thanks for the assistance <3 |
Codecov Report
@@ Coverage Diff @@
## main #11986 +/- ##
=======================================
Coverage 68.74% 68.74%
=======================================
Files 323 323
Lines 16649 16649
Branches 4808 4808
=======================================
Hits 11445 11445
Misses 5171 5171
Partials 33 33
Continue to review full report at Codecov.
|
8c0357a
to
166fd2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
expect.Matchers
generic with single value
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #11985
This broke e.g. the Playwright project.
Test plan
Not sure how to provide tests for this.