Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect detection of open ZLIB handles #12022

Merged
merged 1 commit into from
Nov 2, 2021
Merged

fix: Incorrect detection of open ZLIB handles #12022

merged 1 commit into from
Nov 2, 2021

Conversation

oliversalzburg
Copy link
Contributor

Summary

It appears that some calls into zlib are detected as incorrectly being open. This change ignores open handles in the ZLIB context.

Fixes #11542

Test plan

I added a test for this specific scenario. Before this change is applied, the test fails as expected. With this change applied, the test passes.

image

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #12022 (4ea625d) into main (10d9580) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12022   +/-   ##
=======================================
  Coverage   68.77%   68.77%           
=======================================
  Files         324      324           
  Lines       16669    16670    +1     
  Branches     4813     4814    +1     
=======================================
+ Hits        11464    11465    +1     
  Misses       5172     5172           
  Partials       33       33           
Impacted Files Coverage Δ
packages/jest-core/src/collectHandles.ts 73.52% <100.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10d9580...4ea625d. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! could you add a changelog entry as well? 🙂

It appears that some calls into `zlib` are detected as incorrectly being open. This change ignores open handles in the ZLIB context.

Fixes #11542
@oliversalzburg
Copy link
Contributor Author

Sorry for missing that. I assumed the changelog is automatically generated from git changes. I hope it's good now.

@github-actions
Copy link

github-actions bot commented Dec 4, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--detectOpenHandles reports open handles in ZLIB, but exits cleanly
4 participants