-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Treat snapshots as related to test files #3025
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3025 +/- ##
==========================================
- Coverage 68.49% 68.45% -0.04%
==========================================
Files 146 146
Lines 5335 5338 +3
==========================================
Hits 3654 3654
- Misses 1681 1684 +3
Continue to review full report at Codecov.
|
Yap, this is definitely a step in the right direction to make |
Nice work as always @thymikee. I think we should consider doing something unpopular: create a |
Agreed, |
Master still fails for me using my repro... |
Yeah, I think so. How do you create the gif? :D |
I use LICEcap http://www.cockos.com/licecap/ |
This is odd, same is working for me. I tend to build using |
Seeing as |
Nope, still fails. Is it watchman vs not watchman? Being quick with a ^C allows me to do
|
And what happens when you run |
Is the transform part bad? It points to my locally installed, not the one I run.
With this diff diff --git i/__snapshots__/test.js.snap w/__snapshots__/test.js.snap
index f81294f..2fffbbe 100644
--- i/__snapshots__/test.js.snap
+++ w/__snapshots__/test.js.snap
@@ -2,6 +2,6 @@
exports[`something 1`] = `
Object {
- "input": 42,
+ "output": 42,
}
`; |
That was it! I had to remove my |
Yeah! Awesome to hear that. btw, there's |
And once you |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #2843.
Feel free to close it, if we don't want such behaviour, but I think it's nice.
Test plan
jest-resolve-dependencies
has no tests :(. If we eventually want to merge it, I'll add some.