Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all usage of jest-file-exists. #3101

Merged
merged 1 commit into from
Mar 8, 2017
Merged

Remove all usage of jest-file-exists. #3101

merged 1 commit into from
Mar 8, 2017

Conversation

wtgtybhertgeghgtwtg
Copy link
Contributor

Summary
Removes all usage of the jest-file-exist package. With one exception, it was just a wrapper around fs.existsSync.

Test plan
Nothing should change.

@cpojer
Copy link
Member

cpojer commented Mar 8, 2017

Oh yeah, this is interesting. I think jest-file-exists made more sense when fs.existsSync was deprecated and we were meant to use fs.accessSync instead. I also hoped to optimize the best-case-runtime of this with hasteFS.exists in more places but seems like that wasn't the case :)

Would you mind sending a follow-up PR that actually removes jest-file-exists from the Jest repo? It seems like it is past its lifetime :)

@wtgtybhertgeghgtwtg
Copy link
Contributor Author

I'd be happy to, but isn't that a breaking change?

@cpojer
Copy link
Member

cpojer commented Mar 8, 2017

No, it's fine. If we are not using it within Jest and will never update it ever again, we can simply drop it.

@cpojer cpojer merged commit 5c82046 into jestjs:master Mar 8, 2017
@wtgtybhertgeghgtwtg wtgtybhertgeghgtwtg deleted the drop-jest-file-exists branch March 8, 2017 13:42
skovhus pushed a commit to skovhus/jest that referenced this pull request Apr 29, 2017
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants