Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ansi-regex to pretty-format deps #3498

Merged
merged 1 commit into from
May 7, 2017
Merged

Conversation

thymikee
Copy link
Collaborator

@thymikee thymikee commented May 6, 2017

Summary

Fixes #3495

@codecov-io
Copy link

Codecov Report

Merging #3498 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3498   +/-   ##
=======================================
  Coverage   62.28%   62.28%           
=======================================
  Files         181      181           
  Lines        6700     6700           
  Branches        5        5           
=======================================
  Hits         4173     4173           
  Misses       2525     2525           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38d6139...4030b6b. Read the comment docs.

@cpojer cpojer merged commit 992e991 into jestjs:master May 7, 2017
@cpojer
Copy link
Member

cpojer commented May 7, 2017

Thank you.

@dickeylth
Copy link

Seems need to publish a new version? I've updated jest and thrower an error:

> jest --runInBand

module.js:471
    throw err;
    ^

Error: Cannot find module 'ansi-regex'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/~/node_modules/jest/node_modules/jest-cli/node_modules/jest-util/node_modules/jest-validate/node_modules/pretty-format/build/plugins/ConvertAnsi.js:15:19)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
npm ERR! Test failed.  See above for more details.

@thymikee
Copy link
Collaborator Author

thymikee commented May 8, 2017

We'll publish a patch release soon.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dependency with v20
5 participants