Move getType from jest-matcher-utils to separate package #3559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! I think you can safely add |
Codecov Report
@@ Coverage Diff @@
## master #3559 +/- ##
==========================================
+ Coverage 62.63% 62.65% +0.02%
==========================================
Files 182 183 +1
Lines 6704 6708 +4
Branches 6 6
==========================================
+ Hits 4199 4203 +4
Misses 2502 2502
Partials 3 3
Continue to review full report at Codecov.
|
|
Do you mind rebasing? |
|
Done. |
|
Thank you! |
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This resolves #3528. Move the
getTypeutility function fromjest-matcher-utilsto standalone package. This wayjest-configand other packages don't need to depend onjest-matcher-utilsfor just one function.Test plan
All tests still pass.
Note: When I ranyarn testlocally, It failed to typecheck insidenode_modules/jest-validateas it was looking forgetTypefunction that I just removed. This comes fromprettierdepending onjest-validate. I assumed it was safe to just ignore that typecheck since it is inside node_modules.