Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify snapshots definition (docs) #3790

Merged
merged 1 commit into from
Jun 11, 2017
Merged

Conversation

matteofigus
Copy link
Contributor

Summary

One of the reasons I love jest the most, is snapshot testing. I use it a lot for unit and acceptance testing, so I think UI testing is only a minimal fraction of what snapshots can do and are excellent at.

This is my personal take, feel free to disagree.

Test plan

This PR includes only doc changes

One of the reasons I love jest the most, is snapshot testing. I use it a lot for unit and acceptance testing, so I think UI testing is only a minimal fraction of what snapshots can do and are excellent at.

This is my personal take...but feel free to disagree :)
@codecov-io
Copy link

Codecov Report

Merging #3790 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3790   +/-   ##
=======================================
  Coverage   57.58%   57.58%           
=======================================
  Files         194      194           
  Lines        6776     6776           
  Branches        6        6           
=======================================
  Hits         3902     3902           
  Misses       2871     2871           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5cf182...7f4cff3. Read the comment docs.

@cpojer cpojer merged commit 1277887 into jestjs:master Jun 11, 2017
@cpojer
Copy link
Member

cpojer commented Jun 11, 2017

That makes sense at this point in time! Thank you.

Would you mind making the same changed to the website as well? It's in the website/ folder.

@matteofigus matteofigus deleted the patch-1 branch June 11, 2017 20:27
@matteofigus
Copy link
Contributor Author

Sure thing @cpojer, here it is: #3791

Thanks for working on jest, we ❤️ it at OpenTable 👍

tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
One of the reasons I love jest the most, is snapshot testing. I use it a lot for unit and acceptance testing, so I think UI testing is only a minimal fraction of what snapshots can do and are excellent at.

This is my personal take...but feel free to disagree :)
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants