Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict and explicit config resolution logic #4122

Merged
merged 2 commits into from
Jul 27, 2017

Conversation

aaronabramov
Copy link
Contributor

original pr: #4083
added glob support here aaronabramov@05897b1

@aaronabramov aaronabramov force-pushed the projects_resolution branch 6 times, most recently from dafff27 to 5a8ccf2 Compare July 26, 2017 22:43
@aaronabramov aaronabramov force-pushed the projects_resolution branch from 5a8ccf2 to 0e16326 Compare July 26, 2017 23:04
@aaronabramov
Copy link
Contributor Author

windows failure is unrelated to this PR (#4135)

@codecov-io
Copy link

Codecov Report

Merging #4122 into master will increase coverage by 0.18%.
The diff coverage is 41.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4122      +/-   ##
==========================================
+ Coverage   60.37%   60.55%   +0.18%     
==========================================
  Files         195      196       +1     
  Lines        6768     6777       +9     
  Branches        6        6              
==========================================
+ Hits         4086     4104      +18     
+ Misses       2679     2670       -9     
  Partials        3        3
Impacted Files Coverage Δ
...st-config/src/read_config_file_and_set_root_dir.js 0% <0%> (ø)
packages/jest-config/src/normalize.js 78.26% <0%> (-2.83%) ⬇️
packages/jest-config/src/index.js 0% <0%> (ø) ⬆️
packages/jest-config/src/constants.js 100% <100%> (ø) ⬆️
packages/jest-config/src/resolve_config_path.js 95.65% <95.65%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53bd046...0e16326. Read the comment docs.

@aaronabramov aaronabramov merged commit 2c16d1e into jestjs:master Jul 27, 2017
@aaronabramov aaronabramov deleted the projects_resolution branch July 27, 2017 18:31
@aaronabramov
Copy link
Contributor Author

merging as previous PR was approved

tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
* Stricter config resolution logic

* glob projects
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants