-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use babel transform to inline all requires #4340
Conversation
Are there noticeable speed benefits despite such long whitelist? |
@thymikee I do have a failing test, though 😭
Same one as before, not sure why it fails now... EDIT: No idea about the windows tests on CI, the only failure on my machine is the symbol one (same as circle) |
Same failing test if I whitelist just |
8ca646f
to
f770929
Compare
f770929
to
f1498f3
Compare
f1498f3
to
4124e7e
Compare
scripts/build.js
Outdated
options.plugins.push([ | ||
'transform-inline-imports-commonjs', | ||
{ | ||
allowTopLevelThis: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not needed in the transform-es2015-modules-commonjs
case?
It's happening! Nice collaboration @SimenB :) |
Woo! 🎉 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
See #3786