Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use babel transform to inline all requires #4340

Merged
merged 4 commits into from
Aug 24, 2017

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Aug 24, 2017

See #3786

@thymikee
Copy link
Collaborator

Are there noticeable speed benefits despite such long whitelist?

@SimenB
Copy link
Member Author

SimenB commented Aug 24, 2017

@thymikee Time: 88.466s, estimated 225s (whitelist just jest-matcher-utils uses 79 seconds)

I do have a failing test, though 😭

 FAIL  integration_tests/__tests__/symbol.test.js
  ● Symbol deletion

    TypeError: Cannot read property 'iterator' of undefined

      at Object.<anonymous>.test (integration_tests/__tests__/symbol.test.js:16:14)
          at Promise (<anonymous>)
          at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:188:7)

Same one as before, not sure why it fails now...

EDIT: No idea about the windows tests on CI, the only failure on my machine is the symbol one (same as circle)

@SimenB
Copy link
Member Author

SimenB commented Aug 24, 2017

Same failing test if I whitelist just jest-matcher-utils which is what made #3786 pass...

@cpojer cpojer force-pushed the inline-require-take-2 branch from f770929 to f1498f3 Compare August 24, 2017 14:26
@cpojer cpojer force-pushed the inline-require-take-2 branch from f1498f3 to 4124e7e Compare August 24, 2017 14:28
scripts/build.js Outdated
options.plugins.push([
'transform-inline-imports-commonjs',
{
allowTopLevelThis: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not needed in the transform-es2015-modules-commonjs case?

@cpojer cpojer merged commit 64535a1 into jestjs:master Aug 24, 2017
@cpojer
Copy link
Member

cpojer commented Aug 24, 2017

It's happening! Nice collaboration @SimenB :)

@SimenB SimenB deleted the inline-require-take-2 branch August 24, 2017 15:27
@SimenB
Copy link
Member Author

SimenB commented Aug 24, 2017

Woo! 🎉

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants