Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let "--all" override "--onlyChanged" #5486

Merged
merged 2 commits into from
Feb 7, 2018
Merged

Let "--all" override "--onlyChanged" #5486

merged 2 commits into from
Feb 7, 2018

Conversation

mjesun
Copy link
Contributor

@mjesun mjesun commented Feb 7, 2018

--all must override any --onlyChanged flag.

@mjesun mjesun requested review from cpojer and thymikee February 7, 2018 11:50
@cpojer
Copy link
Member

cpojer commented Feb 7, 2018

Can you add a test for this behavior?

@codecov-io
Copy link

Codecov Report

Merging #5486 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5486      +/-   ##
==========================================
+ Coverage   61.64%   61.66%   +0.01%     
==========================================
  Files         213      213              
  Lines        7069     7069              
  Branches        3        3              
==========================================
+ Hits         4358     4359       +1     
+ Misses       2710     2709       -1     
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-config/src/normalize.js 93.25% <66.66%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79dcdd3...e302a28. Read the comment docs.

@mjesun
Copy link
Contributor Author

mjesun commented Feb 7, 2018

Done! @thymikee again the tar failure in CircleCI. I think it's caused when you push a branch while the builds are running, and CircleCI abruptly stops the process, but they cache an image :(

@cpojer cpojer merged commit 87cd2ff into jestjs:master Feb 7, 2018
@mjesun mjesun deleted the all-only-changed branch February 7, 2018 13:47
@SimenB
Copy link
Member

SimenB commented Feb 8, 2018

@mjesun seems like something we should report to circle

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants