Update testURL default value from about:blank to localhost #6792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
approved these changes
Aug 1, 2018
Codecov Report
@@ Coverage Diff @@
## master #6792 +/- ##
=======================================
Coverage 63.66% 63.66%
=======================================
Files 235 235
Lines 9010 9010
Branches 3 3
=======================================
Hits 5736 5736
Misses 3273 3273
Partials 1 1
Continue to review full report at Codecov.
|
|
needs a changelog entry |
|
I always forget this :) Pushing now |
SimenB
approved these changes
Aug 1, 2018
14 tasks
|
When will this be released? |
ljharb
added a commit
to airbnb/react-component-variations
that referenced
this pull request
Aug 2, 2018
ljharb
added a commit
to airbnb/react-component-variations
that referenced
this pull request
Aug 3, 2018
|
@mjesun mind releasing a patch? |
christinebrass
added a commit
to TrueCar/gluestick
that referenced
this pull request
Aug 10, 2018
abetomo
added a commit
to abetomo/webpack
that referenced
this pull request
Aug 13, 2018
The following errors were fixed.
```
● Test suite failed to run
SecurityError: localStorage is not available for opaque origins
at Window.get localStorage [as localStorage]
(node_modules/jsdom/lib/jsdom/browser/Window.js:257:15)
at Array.forEach (<anonymous>)
```
* https://github.com/facebook/jest/blob/master/CHANGELOG.md#2350
* jestjs/jest#6792
abetomo
added a commit
to abetomo/node-ss2json
that referenced
this pull request
Aug 13, 2018
Resolved at 23.5.0 jestjs/jest#6792
abetomo
added a commit
to abetomo/node-ss2json
that referenced
this pull request
Aug 19, 2018
Resolved at 23.5.0 jestjs/jest#6792
aduth
added a commit
to WordPress/gutenberg
that referenced
this pull request
Sep 12, 2018
Avoids issues with localStorage in JSDOM 11.12 Can be removed when running Jest 23.5.0 or newer See: jestjs/jest#6766 See: jestjs/jest#6792
aduth
added a commit
to WordPress/gutenberg
that referenced
this pull request
Sep 13, 2018
Avoids issues with localStorage in JSDOM 11.12 Can be removed when running Jest 23.5.0 or newer See: jestjs/jest#6766 See: jestjs/jest#6792
mlazowik
added a commit
to mlazowik/create-react-app
that referenced
this pull request
Sep 16, 2018
jestjs/jest#6792 fixes a security error in tests
aduth
added a commit
to WordPress/gutenberg
that referenced
this pull request
Sep 17, 2018
* Framework: Replace element-closest with registered vendor script * Scripts: Add support for license ignore * Framework: Re-pin to newer version of JSDOM Newer version is SemVer-compatible with jest-environment-jsdom and includes support for Element#closest out of the box. jsdom/jsdom#1555 Required to ignore license validation for abab because while it is a compatible license (BSD 3-clause), the package's `license` field is malformed for parse. https://github.com/jsdom/abab/blob/4327de3aae348710094d9f3c1f0c1477d9feb865/package.json#L26 https://github.com/jsdom/abab/blob/master/LICENSE.md * Testing: Add dummy testURL for Jest config Avoids issues with localStorage in JSDOM 11.12 Can be removed when running Jest 23.5.0 or newer See: jestjs/jest#6766 See: jestjs/jest#6792 * Licenses: Add BSD-3-Clause W3C variant as an allowed license Also, check if the license defined in package.json is telling us to look in the license file, instead. * Package: Scripts: Use String#includes for improved code clarity * Package: Scripts: Add CHANGELOG notes for improved license file detection
This was referenced Oct 1, 2018
4 tasks
evanpurkhiser
added a commit
to getsentry/sentry
that referenced
this pull request
Jan 8, 2019
The failed tests that had to be fixed relate to jestjs/jest#6792
evanpurkhiser
added a commit
to getsentry/sentry
that referenced
this pull request
Jan 8, 2019
The failed tests that had to be fixed relate to jestjs/jest#6792
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates jests default value for testURL from 'about:blank' to 'http://localhost'.
This ensures that JSDOM doesn't throw a security error for tests using the jsdom environment.
Should fix #6766
Test plan
All tests pass
cc @thymikee @SimenB