Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing export statement #7127

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Add missing export statement #7127

merged 1 commit into from
Oct 10, 2018

Conversation

qiuhaohao
Copy link
Contributor

Add missing export statement in puppeteer_environment.js

Just found that the puppeteer_environment.js under docs/Puppeteer.md doesn't export the environment

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@mattphillips
Copy link
Contributor

Thanks @qiuhaohao would you mind adding a changelog entry? Also you need to add a semicolon to the end of the export line to fix the lint error

module.exports = PuppeteerEnvironment;

@qiuhaohao qiuhaohao force-pushed the patch-1 branch 2 times, most recently from 14271dc to aed03ec Compare October 10, 2018 03:04
Add missing export statement in puppeteer_environment.js
Add Semicolon

Update CHANGELOG.md

Update CHANGELOG.md
@codecov-io
Copy link

Codecov Report

Merging #7127 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #7127   +/-   ##
======================================
  Coverage    66.6%   66.6%           
======================================
  Files         253     253           
  Lines       10629   10629           
  Branches        4       3    -1     
======================================
  Hits         7079    7079           
  Misses       3549    3549           
  Partials        1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b69eb01...aed03ec. Read the comment docs.

@qiuhaohao
Copy link
Contributor Author

Hi @mattphillips Thanks for the reminder. Should have read the contribution guideline better. It should be fine now: )

@SimenB SimenB merged commit 179b3e8 into jestjs:master Oct 10, 2018
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants