Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get relative path in haste map #7324

Merged
merged 3 commits into from
Nov 3, 2018

Conversation

yamatatsu
Copy link
Contributor

@yamatatsu yamatatsu commented Nov 2, 2018

Summary

close #7323

ex)
dirname: foo/bar
filename: foo/barbaz/index.js

And relative() return az/index.js.

Expected return ../barbaz/index.js

Test plan

Added a test with fix commit.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@SimenB SimenB requested a review from rubennorte November 2, 2018 21:51
@SimenB
Copy link
Member

SimenB commented Nov 2, 2018

Could you update the changelog? :)

Copy link
Contributor

@rubennorte rubennorte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please add the changelog entry and it's good to merge :)

@yamatatsu
Copy link
Contributor Author

Thank you for replying!
I've writen it !!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

Codecov Report

Merging #7324 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7324   +/-   ##
=======================================
  Coverage   66.64%   66.64%           
=======================================
  Files         241      241           
  Lines        9345     9345           
  Branches        5        6    +1     
=======================================
  Hits         6228     6228           
  Misses       3114     3114           
  Partials        3        3
Impacted Files Coverage Δ
packages/jest-haste-map/src/lib/fast_path.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2b51c1...a9aae22. Read the comment docs.

@SimenB SimenB merged commit 9812e1b into jestjs:master Nov 3, 2018
@yamatatsu yamatatsu deleted the fix/fast-path-relative branch November 4, 2018 23:52
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jest-haste-map/src/lib/fast_path.js relative() return wrong path
5 participants