Fix: prettierPath not working via config file #7412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
approved these changes
Nov 26, 2018
| @@ -425,7 +425,7 @@ export const options = { | |||
| type: 'string', | |||
| }, | |||
| prettierPath: { | |||
| default: 'prettier', | |||
| default: undefined, | |||
There was a problem hiding this comment.
Should this still default to 'prettier'?
There was a problem hiding this comment.
Yes. It picks the value from the default config. https://github.com/facebook/jest/blob/master/packages/jest-config/src/Defaults.js#L55
captain-yossarian
pushed a commit
to captain-yossarian/jest
that referenced
this pull request
Jul 18, 2019
* removed default value of prettierPath from argv * updated snapshot for show_config * updated changelog * fixed wrong package name in changelog
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7406 by setting default value of
prettierPathtoundefinedin argv. Also addedprettierPathkey toArgvtype.Test plan
Updated snapshots