-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mistake as test files when run coverage issue. #7506
Conversation
* Check testPathIgnorePatterns. * Add tests.
* Add jestjs#7506 to CHANGELOG.
config.testRegex && | ||
config.testRegex.some(regex => new RegExp(regex).test(filename)) | ||
!config.testPathIgnorePatterns || | ||
!config.testPathIgnorePatterns.some(pattern => filename.match(pattern)) | ||
) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's the same check a bit further down this file: https://github.com/facebook/jest/blob/f38b0c9d17f92f3e0f144087db6264d585bcbeed/packages/jest-runtime/src/should_instrument.js#L79-L84
maybe we can just move it up to this place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thymikee testPathIgnorePatterns
vs coveragePathIgnorePatterns
, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Run coverage the following test environment.
package.json
file tree
Expect:
Actual:
Test plan
Above test result as expected.