Fix buffer property is not ArrayBuffer issue. #7626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In node environment Buffer class buffer property become ArrayBuffer. * Set ArrayBuffer to global.ArrayBuffer. * Add tests.
SimenB
approved these changes
Jan 14, 2019
* Add jestjs#7626 to CHANGELOG.
thymikee
approved these changes
Jan 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #7626 +/- ##
==========================================
- Coverage 68.27% 68.26% -0.01%
==========================================
Files 249 249
Lines 9623 9624 +1
Branches 5 6 +1
==========================================
Hits 6570 6570
- Misses 3051 3052 +1
Partials 2 2
Continue to review full report at Codecov.
|
captain-yossarian
pushed a commit
to captain-yossarian/jest
that referenced
this pull request
Jul 18, 2019
PsychoLlama
added a commit
to PsychoLlama/bin-json
that referenced
this pull request
May 22, 2020
There was an unfortunate quirk of upgrading Jest. They changed their node globals to include an `ArrayBuffer` override, synchronizing the value with `Buffer.from([]).buffer.constructor`. I didn't dive too deep, but what became clear was `new Uint8Array(0).buffer` and `Buffer.from([]).buffer` reference different `ArrayBuffer` constructors. This failed the tests because I was comparing the constructor from two separate realms. See: jestjs/jest#7626 This affects production code, not just tests. Because the global constructor was different between environments, it forced me to check by string tag instead of instance. That's probably a good change anyway. I manually checked the string tag in Node, IE11, Firefox, and Chrome.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In node environment Buffer class buffer property become ArrayBuffer.
Summary
In the following code.
Execute in each environment.(
--env=node,--env=jsdom, andnode)Expect:
Actual:
--env=node, (A) is not true.ref.
https://nodejs.org/api/buffer.html#buffer_buf_buffer
Test plan