Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First setup presets before options validation #7724

Merged
merged 2 commits into from
Jan 27, 2019
Merged

First setup presets before options validation #7724

merged 2 commits into from
Jan 27, 2019

Conversation

doniyor2109
Copy link
Contributor

Summary

setupFilesAfterEnv config from preset is ignored according to #7719

Test plan

Linked jest to https://github.com/sbekrin/jest-24-setup-files-after-env-bug and run tests.

SimenB
SimenB requested changes Jan 27, 2019
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you add a test and update the changelog?

jeysal
jeysal approved these changes Jan 27, 2019
View reviewed changes
Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

SimenB
SimenB approved these changes Jan 27, 2019
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@SimenB SimenB merged commit 9243e69 into jestjs:master Jan 27, 2019
@thymikee thymikee mentioned this pull request Jan 27, 2019
Closed
@xiaoyuhen xiaoyuhen mentioned this pull request Feb 2, 2019
Merged
2 tasks
captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
@doniyor2109 @captain-yossarian
First setup presets before options validation (jestjs#7724)
29b1e1c
@jimmydief jimmydief mentioned this pull request Feb 24, 2020
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeysal jeysal jeysal approved these changes

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@doniyor2109 @SimenB @jeysal @facebook-github-bot