fix: make sure normalize accepts defaults #7742
Conversation
| @@ -200,7 +200,9 @@ const normalizeCollectCoverageFrom = (options: InitialOptions, key: string) => { | |||
| value = JSON.parse(options[key]); | |||
| } catch (e) {} | |||
|
|
|||
| Array.isArray(value) || (value = [options[key]]); | |||
| if (value && !Array.isArray(value)) { | |||
There was a problem hiding this comment.
it ended up being [null], which threw below in the loop.
Also, super weird to use || then assignment...
|
|
||
| describe('Defaults', () => { | ||
| it('should be accepted by normalize', () => { | ||
| normalize({...Defaults, rootDir: '/root'}, {}); |
There was a problem hiding this comment.
rootDir is added by readConfig
There was a problem hiding this comment.
Might want to preserve that information 😄
| normalize({...Defaults, rootDir: '/root'}, {}); | |
| // rootDir is added by readConfig | |
| normalize({...Defaults, rootDir: '/root'}, {}); |
There was a problem hiding this comment.
I don't see a reason, it's used like this all over this test file
SimenB
force-pushed
the
normalize-defaults
branch
from
f9ad1b9 to
28e1361
Compare
|
|
||
| describe('Defaults', () => { | ||
| it('should be accepted by normalize', () => { | ||
| normalize({...Defaults, rootDir: '/root'}, {}); |
There was a problem hiding this comment.
Might want to preserve that information 😄
| normalize({...Defaults, rootDir: '/root'}, {}); | |
| // rootDir is added by readConfig | |
| normalize({...Defaults, rootDir: '/root'}, {}); |
SimenB
force-pushed
the
normalize-defaults
branch
from
28e1361 to
9904a83
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #7741
Test plan
Test added