Fixes 7099 - Better error messages when the jest environment is used after teardown by async code #7756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7756 +/- ##
==========================================
- Coverage 68.39% 68.36% -0.04%
==========================================
Files 252 252
Lines 9694 9700 +6
Branches 6 5 -1
==========================================
+ Hits 6630 6631 +1
- Misses 3062 3067 +5
Partials 2 2
Continue to review full report at Codecov.
|
olivierbeaulieu
deleted the
fix-7099-better-error-message-after-teardown
branch
captain-yossarian
pushed a commit
to captain-yossarian/jest
that referenced
this pull request
Jul 18, 2019
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the issue 7099, following the directions provided by @SimenB.
Fixes #7099
Summary
It's a tweak to help people use existing functionality correctly, as described in the issue
Test plan
I added an integration test that validates the behaviour.