Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate jest-changed-files to Typescript #7827

Merged
merged 5 commits into from
Feb 7, 2019

Conversation

lorenzorapetti
Copy link
Contributor

Summary

Diff:

diff --git a/packages/jest-changed-files/build/hg.js b/packages/jest-changed-files/build/hg.js
index 97a84e96f..27a021d87 100644
--- a/packages/jest-changed-files/build/hg.js
+++ b/packages/jest-changed-files/build/hg.js
@@ -94,7 +94,7 @@ function _defineProperty(obj, key, value) {
 }
 
 const env = _objectSpread({}, process.env, {
-  HGPLAIN: 1
+  HGPLAIN: '1'
 });
 
 const ANCESTORS = [
diff --git a/packages/jest-changed-files/build/index.js b/packages/jest-changed-files/build/index.js
index dbd84f818..5e7db85f2 100644
--- a/packages/jest-changed-files/build/index.js
+++ b/packages/jest-changed-files/build/index.js
@@ -5,10 +5,6 @@ Object.defineProperty(exports, '__esModule', {
 });
 exports.findRepos = exports.getChangedFilesForRoots = void 0;
 
-var _git = _interopRequireDefault(require('./git'));
-
-var _hg = _interopRequireDefault(require('./hg'));
-
 function _throat() {
   const data = _interopRequireDefault(require('throat'));
 
@@ -19,6 +15,10 @@ function _throat() {
   return data;
 }
 
+var _git = _interopRequireDefault(require('./git'));
+
+var _hg = _interopRequireDefault(require('./hg'));
+
 function _interopRequireDefault(obj) {
   return obj && obj.__esModule ? obj : {default: obj};
 }

Test plan

Green CI

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! I left some comments where I think we can be a bit stricter WRT types, but overall this is perfect

e2e/__tests__/jestChangedFiles.test.js Outdated Show resolved Hide resolved
packages/jest-changed-files/src/git.ts Outdated Show resolved Hide resolved
packages/jest-changed-files/src/git.ts Outdated Show resolved Hide resolved
@SimenB
Copy link
Member

SimenB commented Feb 7, 2019

FYI incoming conflict: #7611. I'd like to merge that one first

@SimenB
Copy link
Member

SimenB commented Feb 7, 2019

@loryman it didn't cause conflicts since the file was copied - mind rebasing (making sure the copied types are correct) and addressing the nits? 🙂

@lorenzorapetti
Copy link
Contributor Author

@SimenB yeah sorry now i'm a bit busy, i can update and rebase everything in about 1 hour :)

@SimenB
Copy link
Member

SimenB commented Feb 7, 2019

No rush

SimenB and others added 3 commits February 7, 2019 17:47
Co-Authored-By: loryman <lorenzo.rapetti.94@gmail.com>
Merge remote-tracking branch 'origin/jest-changed-files-typescript' into jest-changed-files-typescript
@lorenzorapetti
Copy link
Contributor Author

lorenzorapetti commented Feb 7, 2019

I've updated everything and made sure typecheck and lint pass 🎉

@SimenB SimenB merged commit ba4e963 into jestjs:master Feb 7, 2019
@lorenzorapetti lorenzorapetti deleted the jest-changed-files-typescript branch February 7, 2019 17:26
captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
* Migrate jest-changed-files to Typescript

* Add changelog entry

* Update e2e/__tests__/jestChangedFiles.test.js

Co-Authored-By: loryman <lorenzo.rapetti.94@gmail.com>

* Stricter typings


Merge remote-tracking branch 'origin/jest-changed-files-typescript' into jest-changed-files-typescript

* Make prettier happy
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants