-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate jest-changed-files to Typescript #7827
Migrate jest-changed-files to Typescript #7827
Conversation
bfabad1
to
45a9d90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again! I left some comments where I think we can be a bit stricter WRT types, but overall this is perfect
FYI incoming conflict: #7611. I'd like to merge that one first |
@loryman it didn't cause conflicts since the file was copied - mind rebasing (making sure the copied types are correct) and addressing the nits? 🙂 |
@SimenB yeah sorry now i'm a bit busy, i can update and rebase everything in about 1 hour :) |
No rush |
06da425
to
b1f7738
Compare
Co-Authored-By: loryman <lorenzo.rapetti.94@gmail.com>
Merge remote-tracking branch 'origin/jest-changed-files-typescript' into jest-changed-files-typescript
I've updated everything and made sure |
* Migrate jest-changed-files to Typescript * Add changelog entry * Update e2e/__tests__/jestChangedFiles.test.js Co-Authored-By: loryman <lorenzo.rapetti.94@gmail.com> * Stricter typings Merge remote-tracking branch 'origin/jest-changed-files-typescript' into jest-changed-files-typescript * Make prettier happy
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Diff:
Test plan
Green CI