-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Migrate bable-plugin-jest-hoist to Typescript #7898
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! left some inline questions 🙂
sure no problem |
Thanks @deneuv34! |
@SimenB BTW, thanks for the feedback! 😃 |
@@ -11,5 +11,12 @@ | |||
}, | |||
"license": "MIT", | |||
"main": "build/index.js", | |||
"types": "build/index.d.ts", | |||
"dependencies": { | |||
"@types/babel__traverse": "^7.0.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not install this type as a dev dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's part of the public interface
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Migrate
babel-plugin-jest-hoist
into typescript.Test plan
Green CI