-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate jest-runtime to TypeScript #7964
Conversation
@@ -0,0 +1,22 @@ | |||
{ | |||
"name": "@jest/environment", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly so I could reuse jest-mock
types
It'll be useful for all test environments, though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @lirbank relevant for your migrations
01b2af6
to
5f6d79a
Compare
5f6d79a
to
455d724
Compare
Pushed a fix for the remaining partial |
Thanks @jeysal, cherry picked! This is ready for review now, if anyone feels up to it. I added the typings for the Jest object to a new package |
Codecov Report
@@ Coverage Diff @@
## master #7964 +/- ##
==========================================
- Coverage 64.78% 64.61% -0.18%
==========================================
Files 256 257 +1
Lines 10045 10067 +22
Branches 1466 1556 +90
==========================================
- Hits 6508 6505 -3
- Misses 3218 3224 +6
- Partials 319 338 +19
Continue to review full report at Codecov.
|
This is a bit painful to keep up to date with master, so I'll merge when CI is green. Feel free to review this after the fact, and I can open up a new PR with fixes proposed |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
I've also messed about with the types of a couple of other packages to make things pass
Built diff:
Test plan
Green CI