-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory leak fix: release source map info after processed and minor optimizations #8234
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8234 +/- ##
==========================================
- Coverage 62.33% 62.29% -0.04%
==========================================
Files 265 265
Lines 10553 10554 +1
Branches 2565 2569 +4
==========================================
- Hits 6578 6575 -3
- Misses 3387 3391 +4
Partials 588 588
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Previously,
sourceMaps
:getSourceMapInfo
and set to an object, even when it was guaranteed to be empty.It's companion,
coverage
, was released from memory but unfortunately using thedelete
operator, which is significantly slower than= undefined
even with modern V8 versions:https://jsperf.com/delete-vs-undefined-vs-null/87
I've resolved the leak and minor performance issues along with a minor change to
formatTestResults
that is slightly more efficient for the same result.Test plan