Resolves the test sequencer even when not explicitly set

[arcanis]

Summary

The default value of the test sequencer isn't resolved unless explicitly set (we only iterate on options, which contains the user-defined options but not the default ones). This diff ensures that we call require.resolve to obtain the real default path of the sequencer (since @jest/core is making the require call, it would fail otherwise under PnP).

Test plan

I modified the code in my cache and checked that my tests were running. We probably should try to add an integration test for PnP at some point.

[SimenB]

We probably should try to add an integration test for PnP at some point.

Yeah...

[SimenB]

good catch. Do we need the if at all? Or can we do what we do on line 463?

  options.testEnvironment = getTestEnvironment({
    rootDir: options.rootDir,
    testEnvironment: options.testEnvironment || DEFAULT_CONFIG.testEnvironment,
  });

So (ish)

  options.testSequencer = getTestSequencer({
    rootDir: options.rootDir,
    testSequencer: options.testSequencer || DEFAULT_CONFIG.testSequencer,
  });

[SimenB]

if so, also remove https://github.com/facebook/jest/blob/c85a5e9b1a8a82d837418d79bdb98493b4df460b/packages/jest-config/src/normalize.ts#L592-L602

[SimenB]

(might be a slippery slope, and should rather be part of a larger refactor of normalize)

[SimenB]

If my comment doesn't make sense, feel free to ignore it 😀

[scotthovestadt]

Thank you! Just a lint error to resolve and then will release it.

[scotthovestadt]

e2e test customTestSequencers.test.ts is failing, looking into it

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.