-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[expect] optimize compare nodes #8368
[expect] optimize compare nodes #8368
Conversation
Thanks for this! Obviously the check is completely unnecessary in some cases. Questions:
|
This has already been checked inside
Very cheap, but |
Thank you for improving the calling code after my too-hurried change to |
@Connormiha Forgot to notice no line under Can you please merge changes from jest/master to avoid conflict, and then add the line, so I can merge your contribution. |
5c5de91
to
9533e4c
Compare
I did rebase from master @pedrottimark |
Codecov Report
@@ Coverage Diff @@
## master #8368 +/- ##
==========================================
- Coverage 62.35% 62.34% -0.01%
==========================================
Files 266 266
Lines 10740 10738 -2
Branches 2611 2611
==========================================
- Hits 6697 6695 -2
Misses 3460 3460
Partials 583 583
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Removed needless checking for
isEqualNode
because it checked before.Used lazy checking for second object.
Test plan