chore: test on node 12 #8411
Merged
chore: test on node 12 #8411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeysal
reviewed
May 2, 2019
4 tasks
SimenB
force-pushed
the
node-12
branch
2 times, most recently
from
fc4c665
to
a77cafc
Compare
thymikee
approved these changes
Aug 19, 2019
|
Actual test errors now 🙂 Two stack trace changes which I'll deal with, and a weird error in precision...
@pedrottimark any idea on why this fails for node 12? |
|
🎉 |
SimenB
added a commit
that referenced
this pull request
Aug 21, 2019
SimenB
added a commit
that referenced
this pull request
Aug 22, 2019
SimenB
added a commit
that referenced
this pull request
Aug 22, 2019
This was referenced Jan 28, 2020
This was referenced Feb 4, 2020
This was referenced Feb 18, 2020
This was referenced Mar 3, 2020
This was referenced Mar 10, 2020
This was referenced Mar 24, 2020
This was referenced Apr 16, 2020
This was referenced Apr 30, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Node 12 is out, and it's shiny!
Test plan
Probably gonna fail due to #8397