Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest-resolve] cache current directory path #8412

Merged
merged 2 commits into from
May 3, 2019

Conversation

Connormiha
Copy link
Contributor

Summary

Just save path.resolve('.') to const because isCurrentDirectory called very often.

Test plan

@codecov-io
Copy link

Codecov Report

Merging #8412 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8412      +/-   ##
==========================================
+ Coverage   62.32%   62.32%   +<.01%     
==========================================
  Files         266      266              
  Lines       10733    10734       +1     
  Branches     2614     2614              
==========================================
+ Hits         6689     6690       +1     
  Misses       3461     3461              
  Partials      583      583
Impacted Files Coverage Δ
packages/jest-resolve/src/defaultResolver.ts 68.57% <50%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4941d12...8555ae0. Read the comment docs.

Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Copy link
Contributor

@scotthovestadt scotthovestadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs changelog :)

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants