-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix babel-plugin-jest-hoist: getting full list of whitelisted globals #8429
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8429 +/- ##
=======================================
Coverage 62.32% 62.32%
=======================================
Files 266 266
Lines 10733 10733
Branches 2614 2615 +1
=======================================
Hits 6689 6689
Misses 3461 3461
Partials 583 583
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Ref #8427
Summary
As mentioned in #8427, Node v12 has changed the enumerability of
global.process
andglobal.Buffer
, thus the list of allowed globals became much shorter. I believe, that suggested change will improve the testing experience because it provides more complete list of available globals that can be safely used in hoisted mocks.Test plan
I ran the e2e test for this plugin and it was all green.
P.S. I signed the CLA.