Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: convert jest-cli and jest-validate to esm #8874

Merged
merged 5 commits into from
Aug 26, 2019
Merged

chore: convert jest-cli and jest-validate to esm #8874

merged 5 commits into from
Aug 26, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Aug 24, 2019

Summary

We wanna migrate off of export = as it's not valid JS. These ones should be free as they already export objects. Marking them as breaking, but it should just be breaking for people using TS - either import or require should work the same

Test plan

Green CI

@codecov-io
Copy link

codecov-io commented Aug 24, 2019 •
edited
Loading

Codecov Report

Merging #8874 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8874   +/-   ##
=======================================
  Coverage   64.12%   64.12%           
=======================================
  Files         275      275           
  Lines       11629    11629           
  Branches     2845     2846    +1     
=======================================
  Hits         7457     7457           
  Misses       3545     3545           
  Partials      627      627
Impacted Files Coverage Δ
packages/babel-plugin-jest-hoist/src/index.ts 0% <ø> (ø) ⬆️
packages/jest-jasmine2/src/index.ts 0% <0%> (ø) ⬆️
packages/jest-jasmine2/src/jasmine/jasmineLight.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e6a8e8...a238374. Read the comment docs.

jeysal
jeysal approved these changes Aug 25, 2019
View reviewed changes
packages/jest-cli/src/index.ts Outdated Show resolved Hide resolved
@SimenB SimenB force-pushed the some-esm-conversion branch from 0c0ab92 to a238374 Compare August 26, 2019 06:44
SimenB
SimenB commented Aug 26, 2019
View reviewed changes
packages/jest/src/jest.ts
@@ -5,6 +5,12 @@
* LICENSE file in the root directory of this source tree.
*/

import * as cli from 'jest-cli';
export {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

followup from last question, should we ditch these exports as well?

A reason not to is that we don't really have a programmatic API yet (and won't from jest 25), so all we'd do is ask people to import directly from @jest/core or jest-cli. I think that if we first ask people to change their imports, we should also give them a real API rather than the internal ones that are used now

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we don't have clear vision of the new API, I wouldn't change that just yet

@SimenB SimenB merged commit 438118a into jestjs:master Aug 26, 2019
@SimenB SimenB deleted the some-esm-conversion branch August 26, 2019 07:26
@spacecowboy23 spacecowboy23 mentioned this pull request Jan 24, 2020
Closed
This was referenced Jan 28, 2020
Open
Open
This was referenced Feb 4, 2020
Open
Open
@SimenB SimenB mentioned this pull request Feb 4, 2020
Closed
This was referenced Feb 11, 2020
Open
Open
Open
Open
This was referenced Feb 25, 2020
Open
Open
This was referenced Mar 3, 2020
Open
Open
@opiation opiation mentioned this pull request Mar 5, 2020
Closed
This was referenced Mar 10, 2020
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Closed
This was referenced Mar 24, 2020
Open
Open
This was referenced Apr 16, 2020
Open
Open
Merged
Closed
Merged
@rsimha rsimha mentioned this pull request Apr 23, 2020
Merged
This was referenced Apr 30, 2020
Closed
Closed
jacobq added a commit to jacobq/gulp-jest that referenced this pull request Sep 21, 2020
@jacobq
fix: import runCLI off default export (fix Nerajno#65)
29605ba 
See the following:

* jestjs/jest#9512 (comment)
* jestjs/jest#8874 (comment)
* stryker-mutator/stryker-js#1983
@jacobq jacobq mentioned this pull request Sep 21, 2020
Merged
jacobq added a commit to jacobq/gulp-jest that referenced this pull request Sep 21, 2020
@jacobq
fix: import runCLI off default export (fix Nerajno#65)
30d4934 
See the following:

* jestjs/jest#9512 (comment)
* jestjs/jest#8874 (comment)
* stryker-mutator/stryker-js#1983
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thymikee thymikee thymikee approved these changes

@jeysal jeysal jeysal approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SimenB @codecov-io @thymikee @jeysal @facebook-github-bot