-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add fakeTimersLolex to the test environments #8925
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8925 +/- ##
==========================================
- Coverage 64.28% 64.28% -0.01%
==========================================
Files 276 276
Lines 11711 11715 +4
Branches 2866 2868 +2
==========================================
+ Hits 7529 7531 +2
- Misses 3550 3552 +2
Partials 632 632
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we somehow mark/comment that it's only temporary and not an official API? On the other hand we don't document it yet, so maybe no need to do it.
It's the same code the api will use |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
In my continuing quest to land Lolex, this PR deals with adding it to the environments. There's no way to activate them, but a user can do
and then use that custom environment. A couple of caveats, though - using
runAllImmediates
will throw since it's not implemented, and there's no way to accesssetSystemTime
Test plan
Tests added. The PR for actually making it accessible via API will include more tests, this is just threading through.