-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jest-diff: Add firstOrLastEmptyLineReplacement option and export 3 diffLines functions #8955
jest-diff: Add firstOrLastEmptyLineReplacement option and export 3 diffLines functions #8955
Conversation
Examples for the next pull request reminded me of problems in edge cases because
To avoid too much chaos in |
Codecov Report
@@ Coverage Diff @@
## master #8955 +/- ##
==========================================
- Coverage 64.2% 63.98% -0.23%
==========================================
Files 276 276
Lines 11718 11638 -80
Branches 2868 2858 -10
==========================================
- Hits 7523 7446 -77
+ Misses 3563 3562 -1
+ Partials 632 630 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda hard to review such a big change, but since the test changes seem ok, the code looks simpler, and there's no red flags, lgtm 😄
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
replace another hard-coded string with an option
export
diffLinesUnified2
whichjest-snapshot
will need to ignore indentationdelete redundant code to reduce inconsistent behavior
Because
diffLines.ts
is completely re-written, you might see if Split view is easier to reviewTest plan
diffs.test.ts
printDiffOrStringified.test.ts.snap