Fix to have length guard #9796
Merged
Fix to have length guard #9796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
approved these changes
Apr 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #9796 +/- ##
=======================================
Coverage 64.87% 64.87%
=======================================
Files 288 288
Lines 12206 12206
Branches 3023 3025 +2
=======================================
Hits 7919 7919
Misses 3646 3646
Partials 641 641
Continue to review full report at Codecov.
|
|
Thanks! 😃 |
sit
added a commit
to sit/Pinano-Discord-Bot
that referenced
this pull request
Apr 12, 2020
Run `npm update`. Manually bump jest version. There are some security updates to try and apply. Somewhere recently jest broke `toHaveLength` which will be fixed in next release (see jestjs/jest#9796), so update test to check length directly.
|
Thanks indeed! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If it isn't broke, don't fix it.
I reverted back to the original guard since the type hasn't changed and it was an ugly nest of conditions.
Test plan
Added a new test case.
fixes #9792