Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't run beforeAll/afterAll in skipped block #9931

Merged
merged 2 commits into from
May 1, 2020

Conversation

jeiea
Copy link
Contributor

@jeiea jeiea commented Apr 30, 2020

Summary

Fixes #6755
Fixes #8379

Test plan

e2e/__tests__/skipBeforeAfterAll.test.ts corresponds to #8379 example. I checked it failed on previous revision.

@SimenB
Copy link
Member

SimenB commented Apr 30, 2020

Nice and clean, thanks! This is missing a file to actually run the e2e test you've added. Something like https://github.com/facebook/jest/blob/7a7710d2c9cdc7da97a3674c36f1ca46f7068f78/e2e/__tests__/importedGlobals.test.ts

CHANGELOG.md Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #9931 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9931   +/-   ##
=======================================
  Coverage   64.23%   64.23%           
=======================================
  Files         292      292           
  Lines       12466    12466           
  Branches     3075     3076    +1     
=======================================
  Hits         8007     8007           
  Misses       3810     3810           
  Partials      649      649           
Impacted Files Coverage Δ
packages/jest-jasmine2/src/treeProcessor.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad1b9dc...77f975d. Read the comment docs.

@SimenB
Copy link
Member

SimenB commented Apr 30, 2020

Looks good, thanks @jeiea! Just missing a test file so the new e2e test actually runs.

@SimenB SimenB merged commit 649796d into jestjs:master May 1, 2020
@SimenB
Copy link
Member

SimenB commented May 1, 2020

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants