chore: remove mapCoverage remainings; remove deprecated CLI options test #9968
Conversation
|
Is it ok to remove the deprecation warning for mapCoverage? Normally I'd say "keep it for a while" but since it's no longer necessary, I'm willing to remove it completely. |
|
I'm down with removing the deprecation warning as well, it has been warning for a few years at this point. Warning was added for the config option |
|
@thymikee rebase? |
|
Sure, will do tomorrow :) |
thymikee
force-pushed
the
remove/mapcoverage
branch
from
b1dac85 to
5387e4f
Compare
|
|
||
| const dir = path.resolve(__dirname, '../deprecated-cli-options'); | ||
|
|
||
| it('Prints deprecation warnings for CLI flags', () => { |
There was a problem hiding this comment.
Having a test for this is useful, but we don't have any other deprecations?
There was a problem hiding this comment.
Yea, was wondering if we should keep it empty and leave a comment, "in case of deprecations, test here". You think it makes sense?
There was a problem hiding this comment.
not sure... is that easier than just digging up this PR again?
There was a problem hiding this comment.
Nevertheless, it would be weird to have a "placeholder" test, just in case. I'll edit the OP and adjust the title so it's easier to find when we need it
thymikee
changed the title
thymikee
changed the title
* master: (30 commits) chore: verify TS project references are correct (jestjs#10941) chore(deps): bump actions/setup-node from v2.1.2 to v2.1.3 (jestjs#10940) docs: Rectify typo in tutorialReactNative (jestjs#10930) chore: patch react-native jest preprocessor to avoid warning Ensure `toContain` only accepts strings when `received` is a string (jestjs#10929) chore: update lockfile after publish v27.0.0-next.2 Document and test custom, async, inline snapshot matcher (jestjs#10922) feat(transform): pass config options through to transformer (jestjs#10926) chore: bump eslint-config-prettier chore: run prettier using eslint chore: update lockfile after publish v27.0.0-next.1 fix: move binary file declaration from runtime to repl (jestjs#10925) chore(test-result): remove deprecated `sourcemap` property (jestjs#10355) chore: remove mapCoverage remainings; remove deprecated CLI options test (jestjs#9968) refactor(jest-runtime,jest-transform): add readonly for some class fields (jestjs#10918) chore: ensure single environment package as well chore: fix failing tests (jestjs#10924) chore: fix lint warning ...
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Address TODOs around mapCoverage.
Additionally removes the
deprecatedCLIOptionstest, as this option was the only one deprecated. Leaving a note so we can dig up this PR and revive the test when necessary.Test plan
CI passes