ktfmt doesn't seem to work in IJ 2024.1.1

[rock3r]

I have the ktfmt plugin installed and enabled in IJC 2024.1.1:

When I reformat the file (cmd-shift-l), it looks like it's using IJ's formatter. If I run ktfmt from the command line, the formatting of the file that I just theoretically reformatted in the IDE changes. This shows ktfmt was not used.

[ColtonIdle]

What if you restart the IDE? Wonder if its this issue that was closed: #229

[rock3r]

Hi Colton! No, still doesn't seem to work after restarting the IDE.

[greyhairredbear]

Hmmm, that's interesting. I've 2024.1.1 (241.15989.150 build) with ktfmt plugin version 1.1.0.49 and it's working with that configuration for all the available styles... Do you have any other formatting tools running? Or maybe an .editorconfig file, which is being used by IntelliJ?

[rock3r]

Sorry it took me a while to get back to you, I was mostly travelling for work :) No .editorconfig file, and no other formatting plugins.

Is it possible that the issue is that I have the reformatting scope set to "Only changes uncommitted to VCS"? If I set it to "whole file" it seems to work fine.

[greyhairredbear]

Oh, that's actually quite possible. I think I know where the issue might be, hopefully I can find the time to look into that soon. Thank you for the hint!

[hovterteryan]

Any update on this? Issue exists on Android Studio Koala based on IJ 2024.1.1

[rock3r]

The next version will work fine in all IJ versions up to 242. I fixed it in #501

[greyhairredbear]

Hi @rock3r, nice work on converting the IntelliJ Plugin to Kotlin! 👏

It has been quite a while since I've been able to look into ktfmt, but I have a question on this: Did the update fix the issue with the "Only changes uncommited to VCS"-setting? My guess was that it had something to do with getFeatures() from the KtfmtFormattingService not returning any partial formatting features. And since I saw the return value of the method did not really change after the update, I got curious :)

[rock3r]

@greyhairredbear no, I didn't alter the plugin behaviour. That is still essentially doing nothing. I also think it's due to the features being declared, but don't know how to implement partial reformatting. Maybe @hick209 can help?

[greyhairredbear]

but don't know how to implement partial reformatting

Yes, me neither. I can't recall if I tried just setting the features, using the existing KtfmtFormattingTask and just see what it does... Seems to me this could work out, but as I said, don't know if I've already tried it 🤷 Maybe I've also refrained from adding that since I didn't have an idea of how to verify it's working as expected, but the VCS-setting might just be a way of testing that