Bug: Pasting a paragraph breaks trimTextContentFromAnchor

[giacomoran]

Lexical version: 0.7.6

Steps To Reproduce

1. Open Lexical Playground with the "Max Length" setting on: https://playground.lexical.dev/?isMaxLength=true
2. Clear the editor
3. Paste a paragraph, where text/html in the clipboard is a <p> tag. (You can copy the entire first paragraph at https://lexical.dev/docs/intro)
4. The text is not pasted. trimTextContentFromAnchor, called by MaxLengthPlugin, crashes as it attempts to remove the root node.

Note that, at https://lexical.dev/docs/intro:

• if you copy the title along with the first paragraph, it will be pasted correctly in the editor
• if you copy only a portion of the paragraph, it will be pasted correctly in the editor

[pratik9333]

Can I work on this bug?

[giacomoran]

That would be great! #3775 might be related.

[pratik9333]

Damn, how are you guys able to notice such bugs? good job!

[pratik9333]

Are there any volunteers who can assign me this issue?

[thegreatercurve]

Feel free @pratik9333

[SalmanWasiKhan]

@pratik9333 Is there any progress on this issue?

[777PolarFox777]

I believe that this line cause the error

lexical/packages/lexical-playground/src/plugins/MaxLengthPlugin/index.tsx

Line 43 in 501f5f5

$restoreEditorState(editor, prevEditorState);

It looks like this method doesn't work correctly, I'm seeing some Nodes in NodeMap having __next field that points to non-existing nodes and that's where the error occurs: createChildrenArray: node does not exist in nodeMap

[alexkalinins]

@777PolarFox777 Yes it is caused by $restoreEditorState.

The same error also appears when pressing enter after reaching the input limit.

[CanRau]

@777PolarFox777 Yes it is caused by $restoreEditorState.

The same error also appears when pressing enter after reaching the input limit.

facing the same issue, interestingly I can't reproduce it in the playground though 🤷🏼

I'm pretty confused now, I actually don't understand how MaxLengthPlugin, trimTextContentFromAnchor doesn't get called yet the error happens and clears the whole editor 🤔

old comment

I believe that this line cause the error

lexical/packages/lexical-playground/src/plugins/MaxLengthPlugin/index.tsx

Line 43 in 501f5f5

$restoreEditorState(editor, prevEditorState);

It looks like this method doesn't work correctly, I'm seeing some Nodes in NodeMap having __next field that points to non-existing nodes and that's where the error occurs: createChildrenArray: node does not exist in nodeMap

Tried to replace it with editor.setEditorState(prevEditorState) but then realized that my prevEditorState contains non-existing __next nodes

So yea trimTextContentFromAnchor seems to do something shady 😅

[CanRau]

Has actually been fixed in #4871 and released in v0.12.1
Just tested and works as expected 🥳

So this issue can be closed I guess

[giacomoran]

It's still not working for me.

Lexical: 0.12.2 (assuming Lexical Playground uses the latest version)
Chrome on MacOS

Screen.Recording.2023-09-14.at.22.26.17.mp4

[khsily]

It's still not working for me.

Lexical: 0.12.2 (assuming Lexical Playground uses the latest version) Chrome on MacOS

Screen.Recording.2023-09-14.at.22.26.17.mp4

I made a PR for this issue. Please check #5020