Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: GridSelection separation from lexical core #5276

Closed
icrosil opened this issue Nov 22, 2023 · 1 comment · Fixed by #5280, #5281, #5291, #5293 or #5334
Closed

Feature: GridSelection separation from lexical core #5276

icrosil opened this issue Nov 22, 2023 · 1 comment · Fixed by #5280, #5281, #5291, #5293 or #5334
Assignees
Labels
core-team core team priority issue discussion enhancement Improvement over existing feature

Comments

@icrosil
Copy link
Contributor

icrosil commented Nov 22, 2023

Why

GridSelection creates unnecessary complexities within code by increasing bundle size and providing functionality that is not required from core use cases. In addition current Selection architecture (BaseSelection, RangeSelection, NodeSelection, GridSelection) used regularly with if conditions and multiple actions based on the selection type.

All of the reasons above are concluding that Selection approach should be refactored with goal of removing GridSelection from core package.

Approach

On internal disucssion with @zurfyx and @fantactuka we've aligned on next steps:

  • gradually moving code away from practices of "| RangeSelection | NodeSelection | GridSelection"
  • removing / deprecating pieces of code that are outdated , or should be covered by one of the selections directly
  • Move GridSelection to a Tables package

Notes

  • Created issue for visibility purpose, so all of upcoming discussions can be done here.
  • All the PRs will be linked here as work will be completed in a several stages.
@HoaPhamThi
Copy link

i am using lexical version 0.12.5, why can't i find GridSelection and $isGridSelection in lexical/table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment