Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Incorrect Table Of Contents Order #5792

Closed
ivailop7 opened this issue Mar 31, 2024 · 4 comments
Closed

Bug: Incorrect Table Of Contents Order #5792

ivailop7 opened this issue Mar 31, 2024 · 4 comments
Labels
tables Relates to Lexical Tables

Comments

@ivailop7
Copy link
Collaborator

Lexical version: 0.14.2

When the heading is within a table, collapsible section or any other type of Element Node, the order inside the Table Of Contents is incorrect and it appends the new headings to the top, rather than in the correct position order.

2024-03-31_22-44-11.mp4
@StyleT
Copy link
Contributor

StyleT commented Apr 5, 2024

IMO headings from within tables shall not appear within TOC :P
It's hard to come up with a sane reason for this to be a valid use case. But I may be terribly wrong.

@StyleT StyleT added the tables Relates to Lexical Tables label Apr 5, 2024
@ivailop7
Copy link
Collaborator Author

ivailop7 commented Apr 6, 2024

IMO headings from within tables shall not appear within TOC :P It's hard to come up with a sane reason for this to be a valid use case. But I may be terribly wrong.

I fully agree on the tables one, but I think the element nodes (Collapsible, Columns) is the more important part here. For tables, with merged cells, I can see the usecase where a row with one cell essentially is a sub-section header, but yeah, not a strong use case. We need to handle either way one way or another

@ivailop7
Copy link
Collaborator Author

@KatsiarynaDzibrova is working on this one

@ivailop7
Copy link
Collaborator Author

Was fixed in #5946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tables Relates to Lexical Tables
Projects
None yet
Development

No branches or pull requests

2 participants