Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Change default skipInitialization to false for registerMutationListener #6846

Closed
etrepum opened this issue Nov 19, 2024 · 5 comments · Fixed by #6857
Closed

Chore: Change default skipInitialization to false for registerMutationListener #6846

etrepum opened this issue Nov 19, 2024 · 5 comments · Fixed by #6857
Labels
good first issue Good for newcomers

Comments

@etrepum
Copy link
Collaborator

etrepum commented Nov 19, 2024

After #6357 the skipInitialization option to registerMutationListener was supposed to change to false. The deprecation period is long past, so it's time to change this default and the associated comments/docs.

Search for skipInitialization to find them all. Change only the docs and the default (DEFAULT_SKIP_INITIALIZATION), do not change any of the code that uses this option (it's already correct).

This change will prevent bugs like wobsoriano/lexical-vue#66

@etrepum etrepum added the good first issue Good for newcomers label Nov 19, 2024
@Shopiley
Copy link
Contributor

Hi, can I take this up?

@etrepum
Copy link
Collaborator Author

etrepum commented Nov 20, 2024

Sure, go ahead

@Shopiley
Copy link
Contributor

Shopiley commented Nov 21, 2024

should I change the comments as well or remove them?

image

e.g The default was previously true for backwards compatibility with <= 0.16.1
but this default is now changed to false in [current version]

@etrepum
Copy link
Collaborator Author

etrepum commented Nov 22, 2024

Yes, use 0.21.0 as the version that it changed

@Shopiley
Copy link
Contributor

Shopiley commented Nov 22, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
2 participants