-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Change default skipInitialization to false for registerMutationListener #6846
Labels
good first issue
Good for newcomers
Comments
Hi, can I take this up? |
Sure, go ahead |
Yes, use 0.21.0 as the version that it changed |
[like] Fadekemi ADEBAYO reacted to your message:
…________________________________
From: Bob Ippolito ***@***.***>
Sent: Friday, November 22, 2024 12:09:01 AM
To: facebook/lexical ***@***.***>
Cc: Fadekemi ADEBAYO ***@***.***>; Mention ***@***.***>
Subject: Re: [facebook/lexical] Chore: Change default skipInitialization to false for registerMutationListener (Issue #6846)
Yes, use 0.21.0 as the version that it changed
—
Reply to this email directly, view it on GitHub<#6846 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATS3PP3D4YEYDYL6LS3PHGT2BZYZ3AVCNFSM6AAAAABSCS4GO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJSGYYDGOBZGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After #6357 the
skipInitialization
option toregisterMutationListener
was supposed to change to false. The deprecation period is long past, so it's time to change this default and the associated comments/docs.Search for
skipInitialization
to find them all. Change only the docs and the default (DEFAULT_SKIP_INITIALIZATION
), do not change any of the code that uses this option (it's already correct).This change will prevent bugs like wobsoriano/lexical-vue#66
The text was updated successfully, but these errors were encountered: