Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention nodes shouldn't be spellcheck'd :) #6788

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Mention nodes shouldn't be spellcheck'd :) #6788

merged 4 commits into from
Nov 11, 2024

Conversation

sevki
Copy link
Contributor

@sevki sevki commented Nov 3, 2024

Makes names no-spell-check which is nice for everyone not called John.

image

@vercel Vercel
Copy link

vercel bot commented Nov 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 10:23am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 10:23am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 29.94 KB (0%)
lexical - esm 29.75 KB (0%)
@lexical/rich-text - cjs 38.56 KB (0%)
@lexical/rich-text - esm 31.64 KB (0%)
@lexical/plain-text - cjs 37.18 KB (0%)
@lexical/plain-text - esm 28.95 KB (0%)
@lexical/react - cjs 40.35 KB (0%)
@lexical/react - esm 33.07 KB (0%)

ivailop7
ivailop7 previously approved these changes Nov 3, 2024
View reviewed changes
@ivailop7
Copy link
Collaborator

ivailop7 commented Nov 3, 2024

Change is OK, but you would need to update the respective tests.

@sevki
Copy link
Contributor Author

sevki commented Nov 5, 2024

I tried running the tests locally but the playwright setup isn't loving my nixos setup :( so couldn't update the golden files. sorry

@etrepum
Copy link
Collaborator

etrepum commented Nov 5, 2024

You could update the examples without being able to run them locally, they are not snapshot tests where tooling is used to update them. Should be fairly straightforward to find them with class="mention" .

Are you installing playwright with the given instructions (npx install playwright) and it still doesn't work? I don't think that the instructions really depend on too many globally installed things, but nixos is quite a bit different so not sure. https://lexical.dev/docs/testing#end-to-end-e2e-tests

potatowagon
potatowagon reviewed Nov 11, 2024
View reviewed changes
packages/lexical-playground/src/nodes/MentionNode.ts
@@ -80,6 +80,7 @@ export class MentionNode extends TextNode {
const dom = super.createDOM(config);
dom.style.cssText = mentionStyle;
dom.className = 'mention';
dom.spellcheck = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a low risk change

@potatowagon potatowagon added this pull request to the merge queue Nov 11, 2024
Merged via the queue into facebook:main with commit 23f4a7e Nov 11, 2024
39 of 40 checks passed
@sevki sevki deleted the patch-1 branch November 11, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potatowagon potatowagon potatowagon approved these changes

@ivailop7 ivailop7 ivailop7 left review comments

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sevki @ivailop7 @etrepum @potatowagon @facebook-github-bot