-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Aria attributes for ContentEditable are ignored #6814
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Nov 10, 2024
size-limit report 📦
|
I dont know if the tests are necessary... but while writing the tests, If i wanted to write test cases where the isEditable is |
vantage-ola
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
November 11, 2024 17:13
etrepum
reviewed
Nov 11, 2024
packages/lexical-react/src/__tests__/unit/LexicalContentEditableElement.test.tsx
Outdated
Show resolved
Hide resolved
packages/lexical-react/src/__tests__/unit/LexicalContentEditableElement.test.tsx
Show resolved
Hide resolved
etrepum
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Aria attributes for ContentEditable element
Closes #6789
Test plan
Before
When adding aria-labelledby to the ContentEditable it is not visible in the dom.
After
The aria-labelledby is visible in the the dom. you can check it out by inspecting element in browser DevTools to verify the ARIA attributes...
TODO
Write a unit test to verify the attributes are properly rendered in the DOM