Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table Action Menu - fix UI issue with Merge Cells item #6830

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Table Action Menu - fix UI issue with Merge Cells item #6830

merged 3 commits into from
Nov 20, 2024

Conversation

umaranis
Copy link
Contributor

Description

Describe the changes in this pull request

Closes ##6829

Test plan

Before

Insert relevant screenshots/recordings/automated-tests
image

After

Insert relevant screenshots/recordings/automated-tests
image

@vercel Vercel
Copy link

vercel bot commented Nov 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 10:56am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 10:56am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 30.85 KB (0%)
lexical - esm 30.73 KB (0%)
@lexical/rich-text - cjs 39.58 KB (0%)
@lexical/rich-text - esm 32.67 KB (0%)
@lexical/plain-text - cjs 38.22 KB (0%)
@lexical/plain-text - esm 29.93 KB (0%)
@lexical/react - cjs 41.35 KB (0%)
@lexical/react - esm 34.03 KB (0%)

etrepum
etrepum reviewed Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the best fix here would be to wrap the button text with <span class="text">…</span> in the merge/unmerge buttons just like all of the other menu items that display correctly without this CSS change

@umaranis
Copy link
Contributor Author

umaranis commented Nov 19, 2024 •
edited
Loading

I think the best fix here would be to wrap the button text with <span class="text">…</span> in the merge/unmerge buttons just like all of the other menu items that display correctly without this CSS change

Agree. Submitted the change on this PR.
Thanks @etrepum

@etrepum etrepum added this pull request to the merge queue Nov 20, 2024
Merged via the queue into facebook:main with commit 80b0b89 Nov 20, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etrepum etrepum etrepum approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umaranis @etrepum @facebook-github-bot