Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lexical] Chore: Update default skipInitialization to false for registerMutationListener #6857

Merged
merged 5 commits into from
Nov 23, 2024
Merged

[Lexical] Chore: Update default skipInitialization to false for registerMutationListener #6857

merged 5 commits into from
Nov 23, 2024
+5 −5

Conversation

Shopiley
Copy link
Contributor

Description

The default value for the skipInitialization option in registerMutationListener was deprecated in #6357 and was intended to change to false. This PR updates the default (DEFAULT_SKIP_INITIALIZATION) and corresponding comments/docs to reflect the correct value - False.

Closes #6846

@vercel Vercel
Copy link

vercel bot commented Nov 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 1:58pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 1:58pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 30.94 KB (0%)
lexical - esm 30.8 KB (0%)
@lexical/rich-text - cjs 39.6 KB (0%)
@lexical/rich-text - esm 32.66 KB (0%)
@lexical/plain-text - cjs 38.2 KB (0%)
@lexical/plain-text - esm 29.92 KB (0%)
@lexical/react - cjs 41.37 KB (0%)
@lexical/react - esm 34 KB (0%)

@Shopiley Shopiley marked this pull request as ready for review November 22, 2024 12:25
@etrepum etrepum added this pull request to the merge queue Nov 23, 2024
Merged via the queue into facebook:main with commit d9014f3 Nov 23, 2024
40 checks passed
@Shopiley Shopiley deleted the change-skipInitializationn-default branch November 23, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etrepum etrepum etrepum approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chore: Change default skipInitialization to false for registerMutationListener
3 participants
@Shopiley @etrepum @facebook-github-bot