Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-selection] Bug Fix: Wrong selection type in $setBlocksType #6867

Merged
merged 1 commit into from
Nov 25, 2024
Merged

[lexical-selection] Bug Fix: Wrong selection type in $setBlocksType #6867

merged 1 commit into from
Nov 25, 2024

Conversation

lytion
Copy link
Contributor

@lytion lytion commented Nov 25, 2024

Description

selection parameter in $setBlocksType is set to RangeSelection however, the function defines selection as a BaseSelection | null type.

@vercel Vercel
Copy link

vercel bot commented Nov 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 1:00pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 1:00pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 25, 2024
@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size
lexical - cjs 30.91 KB (0%)
lexical - esm 30.79 KB (0%)
@lexical/rich-text - cjs 39.62 KB (0%)
@lexical/rich-text - esm 32.65 KB (0%)
@lexical/plain-text - cjs 38.21 KB (0%)
@lexical/plain-text - esm 29.93 KB (0%)
@lexical/react - cjs 41.34 KB (0%)
@lexical/react - esm 34 KB (0%)

@ivailop7 ivailop7 added this pull request to the merge queue Nov 25, 2024
Merged via the queue into facebook:main with commit 149949f Nov 25, 2024
5 checks passed
@lytion lytion deleted the patch-2 branch November 25, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivailop7 ivailop7 ivailop7 approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lytion @ivailop7 @facebook-github-bot