Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a pack for unwanted chrome extensions #3889

Merged
merged 3 commits into from
Oct 26, 2017

Conversation

clong
Copy link
Contributor

@clong clong commented Oct 26, 2017

The purpose of this pack would be to track a list of chrome extensions that:

  • Have been hijacked
  • Serve ads
  • Exhibit sketchy behavior
  • Can't be trusted for whatever reason

The most straightforward way to track extensions seems to be by identifier. Totally open to feedback on this concept.

@facebook-github-bot facebook-github-bot added the cla signed Automated label: Pull Request author has signed the osquery CLA label Oct 26, 2017
@facebook-github-bot
Copy link

@Centurion89 has updated the pull request. View: changes

@muffins muffins added the packs label Oct 26, 2017
@muffins
Copy link
Contributor

muffins commented Oct 26, 2017

ok to test

"BetternetVPN": {
"query": "SELECT * FROM users JOIN chrome_extensions USING (uid) WHERE identifier='gjknjjomckknofjidppipffbpoekiipm';",
"interval": 86400,
"description": "https://www.bleepingcomputer.com/news/security/eight-chrome-extensions-hijacked-to-deliver-malicious-code-to-4-8-million-users/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind wrapping the URLs to additional information in parens similar to the mac attack packs?

"queries": {
"BetternetVPN": {
"query": "SELECT * FROM users JOIN chrome_extensions USING (uid) WHERE identifier='gjknjjomckknofjidppipffbpoekiipm';",
"interval": 86400,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just my 2-cents, but what about doing 3600 for the interval? I feel like for chrome extensions they could be installed pretty quick, and considering this query will likely be enumerating information on client user laptops this query will likely only run once every 3 business days. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, just had 86400 to be safe :)

- 86400 -> 3600
- Wrap URLs
- Remove snapshot
@facebook-github-bot
Copy link

@Centurion89 has updated the pull request. View: changes

@osqueryer
Copy link

👎 The commit 2ba94c2 (Job results: 1037) failed one or more tests (FreeBSD).

@osqueryer
Copy link

👎 The commit 2ba94c2 (Job results: 1038) failed one or more tests (FreeBSD).

@muffins muffins merged commit 5c25184 into osquery:master Oct 26, 2017
fmanco pushed a commit to fmanco/osquery-packs that referenced this pull request Aug 31, 2018
trizt pushed a commit to trizt/osquery that referenced this pull request May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Automated label: Pull Request author has signed the osquery CLA Hacktoberfest packs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants