Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TV documentation fixes needed #1279

Closed
brodycj opened this issue Sep 20, 2019 · 8 comments
Closed

TV documentation fixes needed #1279

brodycj opened this issue Sep 20, 2019 · 8 comments
Labels
Needs Author Feedback An issue or PR which needs the feedback or response from the author. Stale Issues/PR that are not getting much activity and are closer to be closed 📼 Outdated Docs Documentation is there, but outdated or wrong.

Comments

@brodycj
Copy link

brodycj commented Sep 20, 2019

updated:

On Building For TV Devices web page:

  • an internal Android tab seems to have no information
  • it looks like some info still needs to be updated now that Apple TV support was moved into the fork
  • The internal page URL and title are not consistent (see below)

Out of tree page:

Open question:

I am not certain whether or not Apple TV (tvOS) and Android TV will be supported in the same fork in the future. react-native-tvos/react-native-tvos#14 indicates that this may be the case, maybe the fork should be renamed if it will cover both tvOS and Android TV.

see also: #333

/cc @dlowder-salesforce @cpojer @charpeni

@rickhanlonii
Copy link
Member

cc @rachelnabors, the Building For TV Devices is out of date - starting with 0.62 users will need to begin using https://github.com/react-native-community/react-native-tvos to develop TV devices.

@stale
Copy link

stale bot commented Aug 16, 2020

👋 Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues/PR that are not getting much activity and are closer to be closed label Aug 16, 2020
@brodycj
Copy link
Author

brodycj commented Aug 16, 2020

This issue still does not seem to be resolved.

@stale stale bot removed the Stale Issues/PR that are not getting much activity and are closer to be closed label Aug 16, 2020
@Simek
Copy link
Collaborator

Simek commented Nov 3, 2020

This issue still does not seem to be resolved.

Hi @brodybits, can you elaborate on that? What is still missing in the TV devices docs?

@brodycj
Copy link
Author

brodycj commented Nov 3, 2020

The info in the tvOS tab still seems to have information like this:

  • Native layer: React Native Xcode projects all now have Apple TV build targets, with names ending in the string '-tvOS'.
  • react-native init: New React Native projects created with react-native init will have Apple TV target automatically created in their XCode projects.

The out-of-tree page seems to still have some incorrect info, which should be corrected in PR #2308.

@Simek
Copy link
Collaborator

Simek commented Nov 3, 2020

The info in the tvOS tab still seems to have information like this:

@brodybits True, but before those bullets you can see a notice that Android TV part of documentation is deprecated.

Do you think it will be better to remove the whole Android TV content? It is not what we usually do, for example Geolocoation has been removed from the core in 0.60, but the docs content is still in there - https://reactnative.dev/docs/geolocation.

@Simek Simek added the Needs Author Feedback An issue or PR which needs the feedback or response from the author. label Nov 17, 2020
@stale
Copy link

stale bot commented Jan 9, 2022

👋 Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues/PR that are not getting much activity and are closer to be closed label Jan 9, 2022
@github-actions
Copy link

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Author Feedback An issue or PR which needs the feedback or response from the author. Stale Issues/PR that are not getting much activity and are closer to be closed 📼 Outdated Docs Documentation is there, but outdated or wrong.
Projects
None yet
Development

No branches or pull requests

3 participants