From 30e54adce262610f35a8f7062496b02aea6c885c Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Wed, 17 Aug 2022 07:34:09 -0700 Subject: [PATCH] Fix test_buck by providing exported deps for textinput target (#34436) Summary: This is an attempt to fix the broken `test_buck` as the `/textinput` target now needs to access the Kotlin stdlib dependencies ## Changelog [Internal] - Fix test_buck by providing exported deps for textinput target Pull Request resolved: https://github.com/facebook/react-native/pull/34436 Test Plan: Will wait for a CircleCI result Reviewed By: cipolleschi Differential Revision: D38782473 Pulled By: cortinico fbshipit-source-id: 72265c34092372189d75df732b64a1e370453472 --- .../src/main/java/com/facebook/react/views/textinput/BUCK | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/BUCK b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/BUCK index ef99a74bf377eb..7a4dc3e60973a8 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/BUCK @@ -1,4 +1,7 @@ -load("//tools/build_defs/oss:rn_defs.bzl", "YOGA_TARGET", "react_native_dep", "react_native_target", "rn_android_library") +load("//tools/build_defs/oss:rn_defs.bzl", "IS_OSS_BUILD", "YOGA_TARGET", "react_native_android_toplevel_dep", "react_native_dep", "react_native_target", "rn_android_library") + +# TODO(T115916830): Remove when Kotlin files are used in this module +KOTLIN_STDLIB_DEPS = [react_native_android_toplevel_dep("third-party/kotlin:kotlin-stdlib")] if IS_OSS_BUILD else [] rn_android_library( name = "textinput", @@ -33,7 +36,7 @@ rn_android_library( react_native_target("java/com/facebook/react/common/mapbuffer:mapbuffer"), react_native_target("java/com/facebook/react/views/view:view"), react_native_target("java/com/facebook/react/config:config"), - ], + ] + KOTLIN_STDLIB_DEPS, exported_deps = [ react_native_dep("third-party/android/androidx:appcompat"), ],