From 436cf154bb9cf4fc0bcafd7115d33544ce36b759 Mon Sep 17 00:00:00 2001 From: Dulmandakh Date: Thu, 11 Oct 2018 22:06:35 -0700 Subject: [PATCH] bump Android NDK to r17c (#21628) Summary: bump Android NDK to r17c, which is only available revision to download for r17. And it includes bug fixes. Pull Request resolved: https://github.com/facebook/react-native/pull/21628 Differential Revision: D10352162 Pulled By: hramos fbshipit-source-id: d372e55443260242a44a1f73698977a3e361f001 --- .circleci/config.yml | 6 +++--- ContainerShip/Dockerfile.android-base | 2 +- appveyor.yml | 4 ++-- scripts/android-setup.sh | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 682a6732414fe8..9ab04fa45a7ff3 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -49,11 +49,11 @@ aliases: - &restore-cache-ndk keys: - - v3-android-ndk-r17b-{{ checksum "scripts/android-setup.sh" }} + - v3-android-ndk-r17c-{{ checksum "scripts/android-setup.sh" }} - &save-cache-ndk paths: - /opt/ndk - key: v3-android-ndk-r17b-{{ checksum "scripts/android-setup.sh" }} + key: v3-android-ndk-r17c-{{ checksum "scripts/android-setup.sh" }} - &restore-cache-downloads-buck keys: @@ -344,7 +344,7 @@ android_defaults: &android_defaults - ADB_INSTALL_TIMEOUT: 10 - _JAVA_OPTIONS: "-XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap" - GRADLE_OPTS: '-Dorg.gradle.daemon=false -Dorg.gradle.jvmargs="-XX:+HeapDumpOnOutOfMemoryError"' - - ANDROID_NDK: '/opt/ndk/android-ndk-r17b' + - ANDROID_NDK: '/opt/ndk/android-ndk-r17c' - BUILD_THREADS: 2 macos_defaults: &macos_defaults diff --git a/ContainerShip/Dockerfile.android-base b/ContainerShip/Dockerfile.android-base index 6cbc6438c75bdf..433adf5470e122 100644 --- a/ContainerShip/Dockerfile.android-base +++ b/ContainerShip/Dockerfile.android-base @@ -21,7 +21,7 @@ ARG SDK_VERSION=sdk-tools-linux-3859397.zip ARG ANDROID_BUILD_VERSION=27 ARG ANDROID_TOOLS_VERSION=27.0.3 ARG BUCK_VERSION=v2018.07.23.01 -ARG NDK_VERSION=17b +ARG NDK_VERSION=17c ARG NODE_VERSION=8.10.0 ARG WATCHMAN_VERSION=4.9.0 diff --git a/appveyor.yml b/appveyor.yml index 61fe51b3069ac6..c41066d86eca60 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -1,13 +1,13 @@ environment: ANDROID_HOME: "C:\\android-sdk-windows" - ANDROID_NDK: "C:\\android-sdk-windows\\android-ndk-r17b" + ANDROID_NDK: "C:\\android-sdk-windows\\android-ndk-r17c" ANDROID_BUILD_VERSION: 27 ANDROID_TOOLS_VERSION: 27.0.3 GRADLE_OPTS: -Dorg.gradle.daemon=false SDK_TOOLS_URL: https://dl.google.com/android/repository/sdk-tools-windows-3859397.zip - NDK_TOOLS_URL: https://dl.google.com/android/repository/android-ndk-r17b-windows-x86_64.zip + NDK_TOOLS_URL: https://dl.google.com/android/repository/android-ndk-r17c-windows-x86_64.zip matrix: - nodejs_version: 8 diff --git a/scripts/android-setup.sh b/scripts/android-setup.sh index 957875054372cf..c76f520b931854 100644 --- a/scripts/android-setup.sh +++ b/scripts/android-setup.sh @@ -40,7 +40,7 @@ function getAndroidNDK { if [ ! -e $DEPS ]; then cd $NDK_HOME || exit echo "Downloading NDK..." - curl -o ndk.zip https://dl.google.com/android/repository/android-ndk-r17b-linux-x86_64.zip + curl -o ndk.zip https://dl.google.com/android/repository/android-ndk-r17c-linux-x86_64.zip unzip -o -q ndk.zip echo "Installed Android NDK at $NDK_HOME" touch $DEPS