From 53da5858326bbddd2df112f86b2c1e935adc3882 Mon Sep 17 00:00:00 2001 From: Michael Blanchard Date: Mon, 26 Nov 2018 16:47:34 -0800 Subject: [PATCH] Fix: Add displayName to ActivityIndicator (#22417) Summary: Similar to #21950, this adds displayName to `ActivityIndicator`, so it displays the correct component name in snapshots instead of `Component`. Fixes #21937 (a little bit more than it was already fixed). Pull Request resolved: https://github.com/facebook/react-native/pull/22417 Differential Revision: D13205376 Pulled By: TheSavior fbshipit-source-id: 21e71d4980d159a1f33d32d83346b48257ec21d4 --- .../ActivityIndicator/ActivityIndicator.js | 1 + .../__tests__/ActivityIndicator-test.js | 25 +++++++++++++++++++ .../ActivityIndicator-test.js.snap | 10 ++++++++ 3 files changed, 36 insertions(+) create mode 100644 Libraries/Components/ActivityIndicator/__tests__/ActivityIndicator-test.js create mode 100644 Libraries/Components/ActivityIndicator/__tests__/__snapshots__/ActivityIndicator-test.js.snap diff --git a/Libraries/Components/ActivityIndicator/ActivityIndicator.js b/Libraries/Components/ActivityIndicator/ActivityIndicator.js index 62df9c5783ded2..2ad685e1df2dc1 100644 --- a/Libraries/Components/ActivityIndicator/ActivityIndicator.js +++ b/Libraries/Components/ActivityIndicator/ActivityIndicator.js @@ -112,6 +112,7 @@ const ActivityIndicator = ( // $FlowFixMe - TODO T29156721 `React.forwardRef` is not defined in Flow, yet. const ActivityIndicatorWithRef = React.forwardRef(ActivityIndicator); +ActivityIndicatorWithRef.displayName = 'ActivityIndicator'; ActivityIndicatorWithRef.defaultProps = { animating: true, diff --git a/Libraries/Components/ActivityIndicator/__tests__/ActivityIndicator-test.js b/Libraries/Components/ActivityIndicator/__tests__/ActivityIndicator-test.js new file mode 100644 index 00000000000000..8be9b345bfa847 --- /dev/null +++ b/Libraries/Components/ActivityIndicator/__tests__/ActivityIndicator-test.js @@ -0,0 +1,25 @@ +/** + * Copyright (c) Facebook, Inc. and its affiliates. + * + * This source code is licensed under the MIT license found in the + * LICENSE file in the root directory of this source tree. + * + * @format + * @emails oncall+react_native + */ + +'use strict'; + +const React = require('React'); +const ReactTestRenderer = require('react-test-renderer'); +const ActivityIndicator = require('ActivityIndicator'); + +describe('ActivityIndicator', () => { + it('renders correctly', () => { + const instance = ReactTestRenderer.create( + , + ); + + expect(instance.toJSON()).toMatchSnapshot(); + }); +}); diff --git a/Libraries/Components/ActivityIndicator/__tests__/__snapshots__/ActivityIndicator-test.js.snap b/Libraries/Components/ActivityIndicator/__tests__/__snapshots__/ActivityIndicator-test.js.snap new file mode 100644 index 00000000000000..8a7181882a78dd --- /dev/null +++ b/Libraries/Components/ActivityIndicator/__tests__/__snapshots__/ActivityIndicator-test.js.snap @@ -0,0 +1,10 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[`ActivityIndicator renders correctly 1`] = ` + +`;